robdiciuccio commented on a change in pull request #13353:
URL: https://github.com/apache/superset/pull/13353#discussion_r583872600
##########
File path: superset/db_engine_specs/base.py
##########
@@ -456,7 +456,7 @@ def apply_limit_to_sql(cls, sql: str, limit: int, database:
"Database") -> str:
)
return database.compile_sqla_query(qry)
- if LimitMethod.FORCE_LIMIT:
+ if cls.limit_method == LimitMethod.FORCE_LIMIT:
Review comment:
This seems like a big change, but the default `limit_method` is
`LimitMethod.FORCE_LIMIT` and the only overrides are `LimitMethod.WRAP_SQL`
which returns before this block is executed, so this _should_ be ok.
Should we add some tests around this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
