villebro commented on a change in pull request #13137:
URL: https://github.com/apache/superset/pull/13137#discussion_r584505864
##########
File path: docker/pythonpath_dev/superset_config.py
##########
@@ -66,7 +66,10 @@ def get_env_variable(var_name, default=None):
REDIS_RESULTS_DB = get_env_variable("REDIS_CELERY_DB", 1)
RESULTS_BACKEND = FileSystemCache("/app/superset_home/sqllab")
-
+FEATURE_FLAGS = {
+ 'DASHBOARD_NATIVE_FILTERS': True,
+ 'DASHBOARD_CROSS_FILTERS': True,
+}
Review comment:
These probably shouldn't be added yet
##########
File path:
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBar.tsx
##########
@@ -242,22 +232,19 @@ const FilterBar: React.FC<FiltersBarProps> = ({
const handleFilterSelectionChange = (
filter: Pick<Filter, 'id'> & Partial<Filter>,
- extraFormData: ExtraFormData,
- currentState: CurrentFilterState,
+ filtersState: DataMask,
) => {
+ // @ts-ignore
Review comment:
This should probably be cleaned up in a follow-up PR (it seems we need
to refine a few types in `superset-ui`)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
