villebro commented on a change in pull request #13137:
URL: https://github.com/apache/superset/pull/13137#discussion_r584692820
##########
File path: superset-frontend/src/dashboard/reducers/nativeFilters.ts
##########
@@ -75,23 +91,41 @@ export function getInitialState({
return state as NativeFiltersState;
}
+const getUnitState = (
+ unitName: string,
Review comment:
I think this could be clearerif `unitName` were an enum type, something
like `FilterStateType`, after which this function could be renamed
`getFilterState` and `unitName` would be just `type`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
