nikolagigic commented on a change in pull request #13294:
URL: https://github.com/apache/superset/pull/13294#discussion_r586404100
##########
File path: superset/db_engine_specs/presto.py
##########
@@ -356,31 +356,89 @@ def _show_columns(
return columns
column_type_mappings = (
- (re.compile(r"^boolean.*", re.IGNORECASE), types.Boolean()),
- (re.compile(r"^tinyint.*", re.IGNORECASE), TinyInteger()),
- (re.compile(r"^smallint.*", re.IGNORECASE), types.SmallInteger()),
- (re.compile(r"^integer.*", re.IGNORECASE), types.Integer()),
- (re.compile(r"^bigint.*", re.IGNORECASE), types.BigInteger()),
- (re.compile(r"^real.*", re.IGNORECASE), types.Float()),
- (re.compile(r"^double.*", re.IGNORECASE), types.Float()),
- (re.compile(r"^decimal.*", re.IGNORECASE), types.DECIMAL()),
+ (
+ re.compile(r"^boolean.*", re.IGNORECASE),
+ types.Boolean(),
+ utils.GenericDataType.BOOLEAN,
+ ),
+ (
+ re.compile(r"^tinyint.*", re.IGNORECASE),
+ TinyInteger(),
+ utils.GenericDataType.NUMERIC,
+ ),
+ (
+ re.compile(r"^smallint.*", re.IGNORECASE),
+ types.SmallInteger(),
Review comment:
Changed it to keep it consistent
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
