ktmud commented on a change in pull request #13294:
URL: https://github.com/apache/superset/pull/13294#discussion_r586694615
##########
File path: superset/db_engine_specs/postgres.py
##########
@@ -45,6 +47,96 @@ class PostgresBaseEngineSpec(BaseEngineSpec):
engine = ""
engine_name = "PostgreSQL"
+ column_type_mappings = (
+ (
+ re.compile(r"^smallint", re.IGNORECASE),
+ types.SMALLINT,
+ utils.GenericDataType.NUMERIC,
Review comment:
I understand the need to use a list to have priority for RegExp
matching, but will there be a case where two SQLA types may be matched to
different `GenericDataType`? If not, isn't `GenericDataType` already inferred
by SQLA `types`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
