villebro opened a new pull request #13518: URL: https://github.com/apache/superset/pull/13518
### SUMMARY When working on #13484 I noticed that the script that checks for python and frontend changes in the PR wasn't picking up changes to python files: ``` GITHUB_REPO=apache/superset PR_NUMBER=13484 ./scripts/ci_check_no_file_changes.sh python Searching for changes in python files CHANGED FILES: superset-frontend/package-lock.json superset-frontend/package.json superset-frontend/src/dashboard/components/FiltersBadge/selectors.ts superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBar.tsx superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterValue.tsx superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/ControlItems.tsx superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/state.ts superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/utils.ts superset-frontend/src/dashboard/components/nativeFilters/utils.ts superset-frontend/src/dataMask/actions.ts superset-frontend/src/filters/components/Range/buildQuery.ts superset-frontend/src/filters/components/Select/buildQuery.ts superset-frontend/src/filters/components/TimeColumn/TimeColumnFilterPlugin.tsx superset-frontend/src/filters/components/TimeColumn/buildQuery.ts superset-frontend/src/filters/components/TimeColumn/controlPanel.ts superset-frontend/src/filters/components/TimeColumn/images/thumbnail.png superset-frontend/src/filters/components/TimeColumn/index.ts superset-frontend/src/filters/components/TimeColumn/transformProps.ts superset-frontend/src/filters/components/TimeColumn/types.ts superset-frontend/src/filters/components/TimeGrain/TimeGrainFilterPlugin.tsx superset-frontend/src/filters/components/TimeGrain/buildQuery.ts superset-frontend/src/filters/components/TimeGrain/controlPanel.ts superset-frontend/src/filters/components/TimeGrain/images/thumbnail.png superset-frontend/src/filters/components/TimeGrain/index.ts superset-frontend/src/filters/components/TimeGrain/transformProps.ts superset-frontend/src/filters/components/TimeGrain/types.ts superset-frontend/src/filters/components/index.ts superset-frontend/src/filters/utils.ts superset-frontend/src/visualizations/presets/MainPreset.js No changes detected... Exiting with SUCCESS code ``` Turns out GH API calls are paginated. After adding the `per_page` query parameter the full set of changes were reported: ``` GITHUB_REPO=apache/superset PR_NUMBER=13484 ./scripts/ci_check_no_file_changes.sh python Searching for changes in python files CHANGED FILES: superset-frontend/package-lock.json superset-frontend/package.json superset-frontend/src/dashboard/components/FiltersBadge/selectors.ts superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBar.tsx superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterValue.tsx superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/ControlItems.tsx superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/state.ts superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/utils.ts superset-frontend/src/dashboard/components/nativeFilters/utils.ts superset-frontend/src/dataMask/actions.ts superset-frontend/src/filters/components/Range/buildQuery.ts superset-frontend/src/filters/components/Select/buildQuery.ts superset-frontend/src/filters/components/TimeColumn/TimeColumnFilterPlugin.tsx superset-frontend/src/filters/components/TimeColumn/buildQuery.ts superset-frontend/src/filters/components/TimeColumn/controlPanel.ts superset-frontend/src/filters/components/TimeColumn/images/thumbnail.png superset-frontend/src/filters/components/TimeColumn/index.ts superset-frontend/src/filters/components/TimeColumn/transformProps.ts superset-frontend/src/filters/components/TimeColumn/types.ts superset-frontend/src/filters/components/TimeGrain/TimeGrainFilterPlugin.tsx superset-frontend/src/filters/components/TimeGrain/buildQuery.ts superset-frontend/src/filters/components/TimeGrain/controlPanel.ts superset-frontend/src/filters/components/TimeGrain/images/thumbnail.png superset-frontend/src/filters/components/TimeGrain/index.ts superset-frontend/src/filters/components/TimeGrain/transformProps.ts superset-frontend/src/filters/components/TimeGrain/types.ts superset-frontend/src/filters/components/index.ts superset-frontend/src/filters/utils.ts superset-frontend/src/visualizations/presets/MainPreset.js superset/charts/schemas.py superset/common/query_object.py superset/connectors/druid/models.py superset/connectors/sqla/models.py superset/db_engine_specs/base.py superset/utils/core.py tests/core_tests.py tests/dashboard_utils.py tests/databases/commands_tests.py tests/fixtures/birth_names_dashboard.py tests/query_context_tests.py Detected changes in following file: superset/charts/schemas.py Exiting with FAILURE code ``` ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TEST PLAN <!--- What steps should be taken to verify the changes --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
