ktmud commented on a change in pull request #13518:
URL: https://github.com/apache/superset/pull/13518#discussion_r590002469



##########
File path: scripts/ci_check_no_file_changes.sh
##########
@@ -27,7 +27,7 @@ if [[ -z ${PR_NUMBER} ]]; then
   exit 1
 fi
 
-URL="https://api.github.com/repos/${GITHUB_REPO}/pulls/${PR_NUMBER}/files";
+URL="https://api.github.com/repos/${GITHUB_REPO}/pulls/${PR_NUMBER}/files?per_page=1000";

Review comment:
       Looks like I'm late to the party again. The maximum `per_page` size is 
`100` according to the document. To obtain more than 100 items, there is a 
convenient [`pagination` 
helper](https://octokit.github.io/rest.js/v16#pagination) in [GitHub 
script](https://github.com/actions/github-script)
   
   [This 
PR](https://github.com/apache/superset/pull/13498/files#diff-03633ab82f2a106ba87da31b24dcac2432fbda5f3b4bf79901d95bf4d45fc413R31)
 has an example.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to