mccushjack opened a new pull request #13519: URL: https://github.com/apache/superset/pull/13519
### SUMMARY In attempting to use Apache Superset with Teradata, we observed the following: [Topic 1] The connection instructions provided at https://superset.apache.org/docs/databases/teradata can be updated to the latest and most efficient way to connect to an Advanced SQL Engine (formerly Teradata Database) of a Teradata Vantage system. [Topic 2] Most critically, with the current Superset codebase (as of apache-superset v.1.0.1) an error occurs when attempting to perform a simple SELECT query in the SQL Lab; see Figure 1 below. Namely, observe in Figure 1 the "Syntax Error: expected something between the word '<table_Name>' and the 'LIMIT' keyword". The root cause for this error is the improper translation to Teradata SQL of the 'LIMIT' keyword in the Superset back-end. Teradata SQL uses the 'TOP' or 'SAMPLE' keywords instead of 'LIMIT'. Observe that issue #11405 appears to be closely related to this issue. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF    ### TEST PLAN This solution works and is tested with Teradata Vantage, but we are happy to make other modifications if the team supports. ### ADDITIONAL INFORMATION The request all realtes to the follwoing bug New or Changed Public Interfaces The present proposal requires no new or changed public interfaces. New dependencies Only for Teradata connections, the present proposal requires the installation of the teradatasqlalchemy connector, and the teradatasql driver packages to connect to a Teradata Vantage system Advanced SQL Engine Database. These packages are actively maintained and their licenses are Teradata proprietary. The teradatasql license can be found at: https://github.com/Teradata/python-driver/blob/master/LICENSE whereas the teradatasqlalchemy code is not publicly posted at this point. Migration Plan and Compatibility No migration is necessary. The proposed code changes are an extension and non-destructive to the existing code, thus not affecting existing compatibility. Rejected Alternatives No alternative approaches have been considered or rejected. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
