villebro commented on a change in pull request #13484:
URL: https://github.com/apache/superset/pull/13484#discussion_r590136044
##########
File path:
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterValue.tsx
##########
@@ -137,7 +137,7 @@ const FilterValue: React.FC<FilterProps> = ({
width={220}
formData={formData}
// For charts that don't have datasource we need workaround for empty
placeholder
- queriesData={hasDataSource ? state : [{ data: [null] }]}
+ queriesData={hasDataSource ? state : [{ data: [{}] }]}
Review comment:
The type in `ChartDataResponseResult` is `data: DataRecord[]`, so better
to return an empty row.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
