villebro commented on a change in pull request #13484:
URL: https://github.com/apache/superset/pull/13484#discussion_r590172620
##########
File path: superset-frontend/src/dashboard/components/FiltersBadge/selectors.ts
##########
@@ -192,7 +192,7 @@ export const selectNativeIndicatorsForChart = (
if (!isAffectedByScope) {
return IndicatorStatus.Unset;
}
- if (!column) {
+ if (!column && value.length > 0) {
Review comment:
Good point. I believe we should start enforcing the assumption that
`value === null` means unset, all else is set.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
