rusackas commented on pull request #13497: URL: https://github.com/apache/superset/pull/13497#issuecomment-794565211
Agreed with above statements. I understand and agree with the notion that complex components should be broken down _as needed_ to support higher testability. That said, this swings the pendulum too far in the other direction. I don't think 38 files and 2K lines for this component is the right approach either. I'll try to go through this piece by piece and give thoughts as to which files seem necessary (or not) to break up. I think in general, we can cut a component in half as one PR, and then subdivide as needed in subsequent PRs. Breaking a mountain into boulders is one thing, but turning the mountain into sand might be going too far :) Clearly a lot of diligent work went into this PR, so I want to treat the situation respectfully and carefully. Long story short, I'd rather have a file with a thousand lines open, rather than open 20+ IDE tabs and figure out how it all connects. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
