ktmud commented on pull request #13497: URL: https://github.com/apache/superset/pull/13497#issuecomment-794777371
> > I don't understand how a 290 LOC file can be expanded into 2000+ lines. Even excluding tests and LICENSE blurbs, it is at least 3x more code to understand. How is this actually making anything simpler? > > Code structure is important. Code amount also matters! > > When you put 2000 lines I was scared, since I didn't actually write much code. > > Actually it didn't even come close to that, I took all the code and put it in 1 file, removed the license and the signatures of the functions. There are 240 lines of code. I did the same with the original code and there are 190 lines. I believe that this overhead is due to licenses and functions declarations. > > (only the tests are 1000 lines) Did you count all the hooks you created though? I did the same and got 21 non-test files and 700 LOC: https://gist.github.com/ktmud/f5c16eb18bbceda2fd3f998d14f18948 It was almost 700 lines vs 270 lines. Better than my original estimate, but still... it's also 21 files vs 1 file... I can't imagine opening 21 files just trying to understand this one component. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
