kgabryje opened a new pull request #13598: URL: https://github.com/apache/superset/pull/13598
### SUMMARY This PR adds a few UX improvements to dnd feature implemented in https://github.com/apache/superset/pull/13575: 1. Display a ghost button in all DnD components to indicate that user can drop a metric or column in that component. 2. When user starts dragging a column or a metric, display dashed border around control boxes in which the dragged element can be dropped (before - the border was displayed only when user was hovering over a control box) 3. When user drops a saved metric in metrics control box, instead of opening a popover, the metric is created immediately. In order to test the changes, make sure that `ENABLE_EXPLORE_DRAG_AND_DROP` feature flag is enabled ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF https://user-images.githubusercontent.com/15073128/110958401-f53b7600-834c-11eb-8e21-b2d710eaf7d7.mov https://user-images.githubusercontent.com/15073128/110958599-26b44180-834d-11eb-971b-4ca4b2a6b4dc.mov ### TEST PLAN <!--- What steps should be taken to verify the changes --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API CC: @villebro @junlincc @zhaoyongjie @ktmud ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
