ktmud commented on a change in pull request #13598:
URL: https://github.com/apache/superset/pull/13598#discussion_r593519303
##########
File path:
superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndSelectLabel.tsx
##########
@@ -66,7 +66,8 @@ export default function DndSelectLabel<T, O>(
<ControlHeader {...props} />
</HeaderContainer>
<DndLabelsContainer canDrop={canDrop} isOver={isOver}>
- {isEmpty(props.values) ? renderPlaceHolder() : props.valuesRenderer()}
+ {props.valuesRenderer()}
+ {displayGhostButton && renderPlaceHolder()}
Review comment:
Nit: can we rename `renderPlaceHolder` to `renderGhostButton` just to be
consistent?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
