suddjian commented on pull request #13554: URL: https://github.com/apache/superset/pull/13554#issuecomment-799580304
I have nothing against those libraries, but in my opinion we don't currently need a new dependency for simple utilities like this. - The vast majority of hooks from those libraries are not needed right now. - Dependencies need to be evaluated, upgraded, add to build times (`react-use` is already on major version 17!) - Many people are still getting used to hooks, and keeping simple hooks like this in our codebase will help them to learn. - Hooks are a new enough pattern that the "best choice" of utility library is likely to change. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
