ktmud opened a new pull request #13681: URL: https://github.com/apache/superset/pull/13681
### SUMMARY `Metric` from `@superset-ui/chart-controls` is a TypeScript type, which cannot be used in a JSX file and `PropTypes`---it'd just become `undefined` at compile time. We noticed this because our internal CI is failing because of the bad imports (we have a couple of somewhat stricter Jest tests that uses some `superset-frontend` components). Also remove another reference of `@superset-ui/chart-controls/lib/...`----we shouldn't import `lib` files directly unless absolutely necessary as it sometimes messes up with `npm link`. cc @kgabryje @villebro @graceguo-supercat ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A ### TEST PLAN CI ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: #13575 - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
