ktmud commented on a change in pull request #13681:
URL: https://github.com/apache/superset/pull/13681#discussion_r596440795
##########
File path:
superset-frontend/src/explore/components/controls/MetricControl/MetricDefinitionValue.jsx
##########
@@ -18,20 +18,13 @@
*/
import React from 'react';
import PropTypes from 'prop-types';
-import { Metric } from '@superset-ui/chart-controls/lib/types';
import columnType from './columnType';
import AdhocMetricOption from './AdhocMetricOption';
import AdhocMetric from './AdhocMetric';
import savedMetricType from './savedMetricType';
-import adhocMetricType from './adhocMetricType';
const propTypes = {
- option: PropTypes.oneOfType([
- savedMetricType,
- adhocMetricType,
- Metric,
- PropTypes.string,
- ]).isRequired,
+ option: PropTypes.oneOfType([PropTypes.object, PropTypes.string]).isRequired,
Review comment:
This is just a quick fix to appease CI. Long-term solution is to migrate
this file (and many others) to TypeScript and clean up/consolidate
`Metric`/`AdhocMetric` related types.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
