etr2460 commented on a change in pull request #13684:
URL: https://github.com/apache/superset/pull/13684#discussion_r596560291
##########
File path: superset/db_engine_specs/base.py
##########
@@ -86,6 +86,7 @@ class TimeGrain(NamedTuple): # pylint:
disable=too-few-public-methods
"PT15M": __("15 minute"),
"PT0.5H": __("Half hour"),
"PT1H": __("Hour"),
+ "PT2H": __("2 Hours"),
Review comment:
here also uses singular for `5 minute` `10 minute` `15 minute` etc.
##########
File path: superset-frontend/src/explore/controls.jsx
##########
@@ -280,6 +280,7 @@ export const controls = {
['PT5M', '5 minutes'],
['PT30M', '30 minutes'],
['PT1H', '1 hour'],
+ ['PT2H', '2 hours'],
Review comment:
do you think these should be plural or singular? I see both being used
(`5 minutes` but also `6 hour`). Maybe we can standardize while you're in here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
