yardz commented on a change in pull request #13638:
URL: https://github.com/apache/superset/pull/13638#discussion_r600734118
##########
File path:
superset-frontend/src/explore/components/controls/SelectAsyncControl/index.jsx
##########
@@ -68,7 +68,7 @@ const SelectAsyncControl = props => {
};
return (
- <div>
+ <div data-test="SelectAsyncControl">
Review comment:
Yes, normally I do this, but in the case of this test (And others
similar to this), I thought it would be clearer to keep the `test-id` with the
same name as the component.
This will make it clearer at the time of reading and will also help with
other tests to identify which html of this component.
When the HTML is very large it is very hard to find the limits between the
components.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
