rusackas commented on a change in pull request #13638:
URL: https://github.com/apache/superset/pull/13638#discussion_r602018977
##########
File path:
superset-frontend/src/explore/components/controls/SelectAsyncControl/index.jsx
##########
@@ -68,7 +68,7 @@ const SelectAsyncControl = props => {
};
return (
- <div>
+ <div data-test="SelectAsyncControl">
Review comment:
I'm on the fence here... but I'm OK with it as long as the data-test
attr is at the outer element of the component like it is here, and represents
the entirety of the component. Little pieces within the component, like
`subscribe-button` or whatever, should folow the convention.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
