villebro opened a new pull request #13794:
URL: https://github.com/apache/superset/pull/13794


   ### SUMMARY
   Currently the native filter components render irregularly when waiting for 
data to be returned from the database, causing unnecessary zigzagging on the 
filter tab. In addition, the default value selector in the filter config modal 
doesn't have a spinner to indicate that data is loading.
   
   ### AFTER
   Now the minimum size of the filter item is at minimum the same height as the 
AntD select component, leading to a more peaceful loading experience:
   
![filtertab-after](https://user-images.githubusercontent.com/33317356/112464968-d1c0f400-8d6c-11eb-995c-db281a946e04.gif)
   When data is being fetched from the backend, the spinner is activated:
   
![filterconfig-after](https://user-images.githubusercontent.com/33317356/112464978-d685a800-8d6c-11eb-9b16-066e8666497e.gif)
   
   ### Before
   Previously the filter item would contract when the filter component had 
finished retrieving data but had not yet fully rendered the component:
   
![filtertab-before](https://user-images.githubusercontent.com/33317356/112465000-dedde300-8d6c-11eb-82e2-2f1c3e1f4fe8.gif)
   The default value selector didn't show that data was being awaited from the 
backend. Also, when creating a new filter, it would display "No data" (now the 
spinner appears).
   
![filterconfig-before](https://user-images.githubusercontent.com/33317356/112465027-e56c5a80-8d6c-11eb-8eae-01ebedd34188.gif)
   
   
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to