etr2460 commented on pull request #13802: URL: https://github.com/apache/superset/pull/13802#issuecomment-807777898
>should we still allow users to visualize series with 0s, but not nulls? That's a good question. For the case of a stacked bar chart, even when we had the 0 series, there wasn't anything else in the UI that showed those series being returned. I'm not sure how this works with line/area charts, but my guess would be that they don't render in the legend either. Note that this is the current behavior, and my change makes removes series that are all 0s, all nulls, or a mix of both. >Is this PR also affecting Echarts time series or just nvd3? This only affects nvd3. I'm assuming (hoping? praying?) that echarts doesn't have the same performance issue here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
