villebro commented on pull request #13802: URL: https://github.com/apache/superset/pull/13802#issuecomment-808002041
As this is in `viz.py`, it won't affect ECharts. This change might be problematic if a chart has a series that explicitly needs to show 0s. Imagine a line chart showing sales per product: dropping all zeros might give the impression that a product isn't being sold, while it should in fact show up as zero sales. Do you think it would be ok to change this so that this logic only applies to the bar chart? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
