michael-s-molina edited a comment on pull request #13458: URL: https://github.com/apache/superset/pull/13458#issuecomment-808448626
> I have mixed feelings about this. I know the component is negligible in size and purpose but I think I like the fact that you can use it as a small utility component. Either way, the code LGTM and it can go if it reaches consensus. @geido I would say that when you look at the component's name, you can imagine a reusable component used in multiple places. But when you look at the implementation and props you will see that is just a div with almost no behavior and used only in `TableElement`. I have difficulty imagining creating tests and a storybook for this at its current stage. Maybe in the future, if a `Fade` component is required in other places and with more behavior, we can move it to `src/components`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
