michael-s-molina edited a comment on pull request #13458: URL: https://github.com/apache/superset/pull/13458#issuecomment-808467287
> I have a very strong opinion about not assembling components (to be honest i will always be against it). For me, always is a very strong word in the context of software development. I tend to analyze case by case considering the context. > I did a very quick and superficial search and saw several components using "some kind" of fade... Which brings me to the question, why this fade is not being used in more places? Thank you for the search. That's a strong indicator that in fact, we should have a `Fade` component in `src/components`. Can you paste the references here so we can close this PR and open a new one with the objective of creating this new Fade component and consolidate all the references? > I believe that a piece of the reason is precisely because there is no fade in `src/components ` and the idea that "if a component is used only here, I will put it here". I understand that if we already have a component available that will prevent duplications, but this does not mean that every little bit of code that we do should be in the components folder. Generally, when we have classical components like Button we start there, but a lot of components evolve to a shared component and end up in the components folder by merit. I think that this is the case with Fade. If we identify multiple places with this behavior and resolve all use cases using a nice API, then we can move there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
