villebro commented on a change in pull request #13748:
URL: https://github.com/apache/superset/pull/13748#discussion_r604593019
##########
File path:
superset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.jsx
##########
@@ -29,22 +29,19 @@ import {
validateNonEmpty,
} from '@superset-ui/core';
-import SelectControl from './SelectControl';
-import TextControl from './TextControl';
-import CheckboxControl from './CheckboxControl';
-
+import SelectControl from 'src/explore/components/controls/SelectControl';
+import TextControl from 'src/explore/components/controls/TextControl';
+import CheckboxControl from 'src/explore/components/controls/CheckboxControl';
Review comment:
I personally prefer relative imports if they're in the same directory,
but I don't have strong opinions on this. But it would be nice if we could
enforce this with with some linting rules, e.g. requiring relative imports if
in the same or parent directory, and absolute if elsewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
