suddjian commented on a change in pull request #13773:
URL: https://github.com/apache/superset/pull/13773#discussion_r605134110
##########
File path: superset/views/core.py
##########
@@ -1869,6 +1875,19 @@ def dashboard( # pylint: disable=too-many-locals
if key not in [param.value for param in
utils.ReservedUrlParameters]
}
+ extra_jwt = {}
+ if feature_flag_manager.is_feature_enabled("DASHBOARD_RBAC"):
Review comment:
There is a project underway to make Dashboards part of a single page
app. This code will only work if dashboards are accessed from this route, but
in a SPA that will not necessarily be the case. If you click a link to a
dashboard from the dashboards list or the homepage, the routing will be done on
the frontend. Maybe this code should be moved to a separate endpoint that the
frontend calls to get the jwt.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
