suddjian commented on a change in pull request #13773:
URL: https://github.com/apache/superset/pull/13773#discussion_r605229870
##########
File path: superset/views/core.py
##########
@@ -1869,6 +1875,19 @@ def dashboard( # pylint: disable=too-many-locals
if key not in [param.value for param in
utils.ReservedUrlParameters]
}
+ extra_jwt = {}
+ if feature_flag_manager.is_feature_enabled("DASHBOARD_RBAC"):
Review comment:
I'm expecting to have a PR up that removes dashboard as a standalone app
this week, so I think compatibility is an important consideration now.
What about adding logic to the security of the chart data and dataset
endpoints, to check whether access should be granted at the time of request? Is
that an option? Sorry if I'm missing something, I'd just like to fully
understand the need for this JWT pattern. Is the time limit for access a
feature requirement or an implementation detail?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
