dpgaspar commented on a change in pull request #13906:
URL: https://github.com/apache/superset/pull/13906#discussion_r605615780
##########
File path: superset/config.py
##########
@@ -366,6 +366,8 @@ def _try_json_readsha( # pylint: disable=unused-argument
# always be the table layout
if DEFAULT_FEATURE_FLAGS["THUMBNAILS"]:
DEFAULT_FEATURE_FLAGS["LISTVIEWS_DEFAULT_CARD_VIEW"] = True
+else:
+ DEFAULT_FEATURE_FLAGS["LISTVIEWS_DEFAULT_CARD_VIEW"] = False
Review comment:
nit: this is equal to
```
DEFAULT_FEATURE_FLAGS["LISTVIEWS_DEFAULT_CARD_VIEW"] =
DEFAULT_FEATURE_FLAGS["THUMBNAILS"]
```
Does it still make sense to have this feature flag?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
