rusackas commented on a change in pull request #13906:
URL: https://github.com/apache/superset/pull/13906#discussion_r608884506
##########
File path: superset/config.py
##########
@@ -366,6 +366,8 @@ def _try_json_readsha( # pylint: disable=unused-argument
# always be the table layout
if DEFAULT_FEATURE_FLAGS["THUMBNAILS"]:
DEFAULT_FEATURE_FLAGS["LISTVIEWS_DEFAULT_CARD_VIEW"] = True
+else:
+ DEFAULT_FEATURE_FLAGS["LISTVIEWS_DEFAULT_CARD_VIEW"] = False
Review comment:
@pkdotson @nytai @bkyryliuk @junlincc It sounds like there's an easy
solution, then - two completely separate feature flags:
* `THUMBNAILS` - turns thumbnail generation on, and shows the thumbnails
(default or generated) in the cards. Set to `False` by default.
* `LISTVIEWS_DEFAULT_CARD_VIEW` - set separately, with no
dependence/reliance with the `THUMBNAILS` - its only purpose in life is to set
the status of the card/list toggle. Set to `False` by default.
If that works for everyone, this PR can simply get rid of this whole chunk,
and let the flags live their own separate lives:
```
# Set the default view to card/grid view if thumbnail support is enabled.
# Setting LISTVIEWS_DEFAULT_CARD_VIEW to False will force the default view to
# always be the table layout
if DEFAULT_FEATURE_FLAGS["THUMBNAILS"]:
DEFAULT_FEATURE_FLAGS["LISTVIEWS_DEFAULT_CARD_VIEW"] = True
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
