betodealmeida commented on a change in pull request #13960:
URL: https://github.com/apache/superset/pull/13960#discussion_r607985491
##########
File path: superset/databases/api.py
##########
@@ -604,13 +609,8 @@ def test_connection( # pylint:
disable=too-many-return-statements
# This validates custom Schema with custom validations
except ValidationError as error:
return self.response_400(message=error.messages)
- try:
- TestConnectionDatabaseCommand(g.user, item).run()
- return self.response(200, message="OK")
- except DatabaseTestConnectionFailedError as ex:
- return self.response_422(message=str(ex))
- except SupersetErrorException as ex:
- return self.response(ex.status, message=ex.error.message)
+ TestConnectionDatabaseCommand(g.user, item).run()
+ return self.response(200, message="OK")
Review comment:
Good catch, I'll fix!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
