etr2460 commented on a change in pull request #13960:
URL: https://github.com/apache/superset/pull/13960#discussion_r608154010
##########
File path: docs/src/pages/docs/Miscellaneous/issue_codes.mdx
##########
@@ -113,3 +113,21 @@ The host might be down, and cannot be reached on the
provided port.
The host provided when adding a new database doesn't seem to be up.
Additionally, it cannot be reached on the provided port. Please check that
there are no firewall rules preventing access to the host.
+
+## Issue 1010
+
+```
+Superset found an error while running a command.
+```
+
+Something unexpected happened, and Superset encountered an error while
+running a command. Please reach out to your administrator.
+
+## Issue 1011
+
+```
+Superset found an unexpected error.
Review comment:
nit: i prefer `encountered` here to `found`
```suggestion
Superset encountered an error while running a command.
```
Something unexpected happened, and Superset encountered an error while
running a command. Please reach out to your administrator.
## Issue 1011
```
Superset encountered an unexpected error.
```
##########
File path: superset/errors.py
##########
@@ -135,6 +139,20 @@ class SupersetErrorType(str, Enum):
),
},
],
+ SupersetErrorType.GENERIC_COMMAND_ERROR: [
+ {
+ "code": 1010,
+ "message": _(
+ "Issue 1010 - Superset found an error while running a command."
+ ),
+ },
+ ],
+ SupersetErrorType.GENERIC_BACKEND_ERROR: [
+ {
+ "code": 1011,
+ "message": _("Issue 1011 - Superset found an unexpected error."),
Review comment:
same comment here
```suggestion
"Issue 1010 - Superset encountered an error while running a
command."
),
},
],
SupersetErrorType.GENERIC_BACKEND_ERROR: [
{
"code": 1011,
"message": _("Issue 1011 - Superset encountered an unexpected
error."),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
