AAfghahi commented on a change in pull request #13981:
URL: https://github.com/apache/superset/pull/13981#discussion_r608311508



##########
File path: superset-frontend/src/views/CRUD/data/savedquery/SavedQueryList.tsx
##########
@@ -332,6 +331,15 @@ function SavedQueryList({
               icon: 'Copy',
               onClick: handleCopy,
             },
+            canExport

Review comment:
       It seems like canEdit/canExport/canDelete all have boolean values, is 
that correct? 
   
   If so, would it be better to do like canEdit && the action as opposed to the 
ternary? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to