betodealmeida commented on a change in pull request #13981:
URL: https://github.com/apache/superset/pull/13981#discussion_r608323013



##########
File path: superset-frontend/src/views/CRUD/data/savedquery/SavedQueryList.tsx
##########
@@ -97,6 +98,7 @@ function SavedQueryList({
 
   const canEdit = hasPerm('can_write');
   const canDelete = hasPerm('can_write');
+  const canExport = hasPerm('can_read');

Review comment:
       We should only show the export buttons if the `VERSIONED_EXPORT` feature 
flag is enabled, so this needs to be something like this:
   
   ```js
   const canExport =
       hasPerm('can_read') && isFeatureEnabled(FeatureFlag.VERSIONED_EXPORT);
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to