graceguo-supercat commented on a change in pull request #13980:
URL: https://github.com/apache/superset/pull/13980#discussion_r608361687
##########
File path: superset/config.py
##########
@@ -1125,9 +1128,9 @@ class CeleryConfig: # pylint:
disable=too-few-public-methods
GLOBAL_ASYNC_QUERIES_TRANSPORT = "polling"
GLOBAL_ASYNC_QUERIES_POLLING_DELAY = 500
-# It's possible to add a dataset health check logic which is specific to your
system.
-# It will get executed each time when user open a chart's explore view.
-DATASET_HEALTH_CHECK = None
+# A SQL dataset health check. Note if enabled the callable should be cached to
aid with
+# performance.
Review comment:
1. If the healthy status is in `cache` but not persist in database, when
restart server will we lost all the status?
2. right now we can run some queries to see healthy status. if use `cache`
solution we will not be easy to know this number?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
