ktmud commented on a change in pull request #13980:
URL: https://github.com/apache/superset/pull/13980#discussion_r608366528
##########
File path: superset/connectors/sqla/models.py
##########
@@ -702,13 +702,7 @@ def data(self) -> Dict[str, Any]:
data_["fetch_values_predicate"] = self.fetch_values_predicate
data_["template_params"] = self.template_params
data_["is_sqllab_view"] = self.is_sqllab_view
- # Don't return previously populated health check message in case
- # the health check feature is turned off
- data_["health_check_message"] = (
- self.health_check_message
- if config.get("DATASET_HEALTH_CHECK")
- else None
- )
+ data_["health_check_message"] = self.health_check_message
Review comment:
```suggestion
data_["health_check_message"] = self.check_health()
```
If this will run an external function every time this line is visited, maybe
it's better to change this property to an actual function call so it "looks"
more expensive...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
