ktmud commented on pull request #13980:
URL: https://github.com/apache/superset/pull/13980#issuecomment-815107869


   On second thought, I'm still a little torn between having Superset manages 
the cache vs shifting the responsibility to the end users. IMO the config file 
should be as lightweight as possible. The more logics we force users to put in 
there, the more likely things would break.
   
   I'm wondering whether we can utilize sqla's 
[`before_insert`](https://docs.sqlalchemy.org/en/13/orm/events.html#sqlalchemy.orm.events.MapperEvents.before_insert)
 and 
[`before_update`](https://docs.sqlalchemy.org/en/13/orm/events.html#sqlalchemy.orm.events.MapperEvents.before_update)
 events to run health checks on db updates instead of calling `check_health()` 
in views, so that the check function won't trigger a new update?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to