dpgaspar commented on a change in pull request #13828:
URL: https://github.com/apache/superset/pull/13828#discussion_r609920569
##########
File path: superset/utils/csv.py
##########
@@ -65,3 +67,20 @@ def df_to_escaped_csv(df: pd.DataFrame, **kwargs: Any) ->
Any:
df = df.applymap(escape_values)
return df.to_csv(**kwargs)
+
+
+def get_chart_csv_data(
+ chart_url: Optional[str], auth_cookies: Optional[Dict[str, str]] = None
Review comment:
Why is this `Optional` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
