ktmud commented on a change in pull request #13980:
URL: https://github.com/apache/superset/pull/13980#discussion_r609998995
##########
File path: superset/views/core.py
##########
@@ -734,7 +734,7 @@ def explore( # pylint:
disable=too-many-locals,too-many-return-statements,too-m
# if feature enabled, run some health check rules for sqla
datasource
if hasattr(datasource, "health_check"):
- datasource.health_check()
+ datasource.health_check_message = datasource.health_check()
Review comment:
Does this override the default `@property` getter or just update the
cache?
##########
File path: superset/views/core.py
##########
@@ -734,7 +734,7 @@ def explore( # pylint:
disable=too-many-locals,too-many-return-statements,too-m
# if feature enabled, run some health check rules for sqla
datasource
if hasattr(datasource, "health_check"):
Review comment:
Wouldn't this be always false because you remove the `health_check`
method/attribute from `SqlaDatasource`?
##########
File path:
superset/migrations/versions/134cea61c5e7_remove_dataset_health_check_message.py
##########
@@ -0,0 +1,68 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""remove dataset health check message
+
+Revision ID: 134cea61c5e7
+Revises: 301362411006
+Create Date: 2021-04-07 07:21:27.324983
+
+"""
+
+# revision identifiers, used by Alembic.
+revision = "134cea61c5e7"
+down_revision = "301362411006"
+
+import json
+import logging
+
+from alembic import op
+from sqlalchemy import Column, Integer, Text
+from sqlalchemy.ext.declarative import declarative_base
+
+from superset import db
+
+Base = declarative_base()
+
+
+class SqlaTable(Base):
+ __tablename__ = "tables"
+
+ id = Column(Integer, primary_key=True)
+ extra = Column(Text)
+
+
+def upgrade():
+ bind = op.get_bind()
+ session = db.Session(bind=bind)
+
+ for datasource in session.query(SqlaTable):
+ if datasource.extra:
Review comment:
```suggestion
if datasource.extra and "health_check" in datasource.extra:
```
This should limit following ops to a smaller subset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
