john-bodley commented on a change in pull request #13980:
URL: https://github.com/apache/superset/pull/13980#discussion_r610055674
##########
File path: superset/views/core.py
##########
@@ -734,7 +734,7 @@ def explore( # pylint:
disable=too-many-locals,too-many-return-statements,too-m
# if feature enabled, run some health check rules for sqla
datasource
if hasattr(datasource, "health_check"):
- datasource.health_check()
+ datasource.health_check_message = datasource.health_check()
Review comment:
@ktmud good call. Lines 735–737 can actually be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
