rusackas commented on a change in pull request #13996:
URL: https://github.com/apache/superset/pull/13996#discussion_r612176462



##########
File path: 
superset-frontend/spec/javascripts/dashboard/components/Header_spec.jsx
##########
@@ -83,7 +84,11 @@ describe('Header', () => {
   };
 
   function setup(overrideProps) {
-    const wrapper = shallow(<Header {...props} {...overrideProps} />);
+    const wrapper = mount(
+      <ThemeProvider theme={supersetTheme}>

Review comment:
       You can skip this, and the `superset-ui` imports, by using the helper 
util:
   `import { styledMount as mount } from 'spec/helpers/theming';`
   or 
   `import { styledShallow as shallow } from 'spec/helpers/theming';`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to