michael-s-molina commented on a change in pull request #13996:
URL: https://github.com/apache/superset/pull/13996#discussion_r612457712
##########
File path: superset-frontend/spec/javascripts/sqllab/ShareSqlLabQuery_spec.jsx
##########
@@ -27,6 +27,7 @@ import { render, screen, act } from '@testing-library/react';
import '@testing-library/jest-dom/extend-expect';
import userEvent from '@testing-library/user-event';
import * as utils from 'src/utils/common';
+import { hexToRgb } from 'src/utils/colorUtils';
Review comment:
> I could also see it being useful elsewhere though in the future... and
maybe even extended handle hex+alpha -> RGBa. A similar util for HSL(a) could
also come in handy from time to time.
That was the intention. A global utility (not only for tests), starting with
RGB to HEX and HEX to RGB conversions. I hope to see it with more functions in
the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
