[GitHub] [superset] lyndsiWilliams opened a new pull request #14150: fix: Center each import icon and add a tooltip

[GitBox]

lyndsiWilliams opened a new pull request #14150:
URL: https://github.com/apache/superset/pull/14150


   ### SUMMARY
   I have added a tooltip with text "Import [object]" (example: "Import 
Database", "Import Dataset", etc.) on all occurrences of the import icon: 
Database, Dataset, Chart, Dashboard, Saved Query. I have also centered each 
tooltip icon.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   #### BEFORE:
   <img width="386" alt="import-icon-before" 
src="https://user-images.githubusercontent.com/55605634/114792120-5dff7f00-9d4d-11eb-9197-ad697d4a8e61.png";>
   
   #### AFTER:
   <img width="319" alt="import-icon-after" 
src="https://user-images.githubusercontent.com/55605634/114792148-6657ba00-9d4d-11eb-897d-25799d6d283c.png";>
   
   
   ### TEST PLAN
   - Navigate to all pages with an import icon (Database, Dataset, Chart, 
Dashboard, Saved Query)
   - Observe that the icon is centered with it's neighboring button(s)
   - Hover mouse pointer over the import icon
   - Observe the appropriate relative "Import [object]" tooltip
   
   ### ADDITIONAL INFORMATION
   - [x] Has associated issue: https://github.com/apache/superset/issues/13920
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org