nytai commented on a change in pull request #14150:
URL: https://github.com/apache/superset/pull/14150#discussion_r613670789
##########
File path: superset-frontend/src/views/CRUD/chart/ChartList.tsx
##########
@@ -545,14 +552,24 @@ function ChartList(props: ChartListProps) {
}
if (isFeatureEnabled(FeatureFlag.VERSIONED_EXPORT)) {
subMenuButtons.push({
- name: <Icons.Import />,
+ name: (
+ <Tooltip
+ id="import-tooltip"
+ title={t('Import Chart')}
+ placement="bottomRight"
+ >
+ <Icons.Import />
+ </Tooltip>
+ ),
buttonStyle: 'link',
onClick: openChartImportModal,
});
}
return (
<>
- <SubMenu name={t('Charts')} buttons={subMenuButtons} />
+ <StyledNavbarRight>
Review comment:
Does it make sense to just apply these styles to the SubMenu? Seems like
the default behavior/expectation is that these items are centered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
