eschutho commented on a change in pull request #14146:
URL: https://github.com/apache/superset/pull/14146#discussion_r613696136
##########
File path: superset/db_engine_specs/mysql.py
##########
@@ -50,6 +50,9 @@
TEST_CONNECTION_HOST_DOWN_REGEX = re.compile(
"Can't connect to MySQL server on '(?P<hostname>.*?)'."
)
+TEST_CONNECTION_UNKNOWN_DATABASE_REGEX = re.compile(
+ "Unknown database '(?P<database>.*?)'."
+)
Review comment:
are these going to be the same errors that we'll hit when "creating" a
db? Should we be prefixing them all with "TEST?" or it that too specific?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
