EBoisseauSierra commented on a change in pull request #14102: URL: https://github.com/apache/superset/pull/14102#discussion_r613838361
########## File path: CONTRIBUTING.md ########## @@ -418,22 +420,23 @@ For example, the image referenced above actually lives in `superset-frontend/ima #### OS Dependencies -Make sure your machine meets the [OS dependencies](https://superset.apache.org/docs/installation/installing-superset-from-scratch#os-dependencies) before following these steps. +Make sure your machine meets the [OS dependencies](https://superset.apache.org/docs/installation/installing-superset-from-scratch#os-dependencies) before following these steps. +You also need to install MySQL or [MariaDB](https://mariadb.com/downloads). Review comment: ~~Oh, that might well be required in the tests as well (I suppose due to [`psycopg`](https://github.com/apache/superset/blob/master/requirements/development.txt#L26)).~~ Actually, I tried to install Superset (1.1.0) on a _blank_ F32 VM (`rpm -qa | grep postgres` returns empty) alongside its test dependencies (cf. #14052 ) and, up to running the tests themselves (`$ tox`), no issue was raised (unlike for MySQL). Do we agree we only want to mention these OS dependencies in the “set up your system to run the tests” (and not in the [install from scratch](https://github.com/apache/superset/blob/master/docs/src/pages/docs/installation/installing_scratch.mdx) docs), as we wouldn't want users to install both RDBMS by default? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
