EBoisseauSierra commented on a change in pull request #14102: URL: https://github.com/apache/superset/pull/14102#discussion_r615689001
########## File path: CONTRIBUTING.md ########## @@ -418,22 +420,23 @@ For example, the image referenced above actually lives in `superset-frontend/ima #### OS Dependencies -Make sure your machine meets the [OS dependencies](https://superset.apache.org/docs/installation/installing-superset-from-scratch#os-dependencies) before following these steps. +Make sure your machine meets the [OS dependencies](https://superset.apache.org/docs/installation/installing-superset-from-scratch#os-dependencies) before following these steps. +You also need to install MySQL or [MariaDB](https://mariadb.com/downloads). Review comment: @willbarrett & @rusackas : it looks like `psycopg2-binary` [doesn't require](https://www.psycopg.org/docs/install.html) an explicit PG install, while `mysqlclient` [does have](https://pypi.org/project/mysqlclient/) OS dependencies. So çaybe would it be better to refer to `mysqlclient` page for installs (where both `brew` and `apt`/`yum` methods are detailed… and hopefully maintained), rather than to vanilla MySQL/MariaDB pages; what do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
