craig-rueda commented on a change in pull request #14163:
URL: https://github.com/apache/superset/pull/14163#discussion_r614192555



##########
File path: .github/workflows/superset-helm-release.yml
##########
@@ -0,0 +1,33 @@
+name: Release Charts
+
+on:
+  push:
+    branches:
+      - '**'

Review comment:
       Let's only do this on master

##########
File path: .github/workflows/superset-helm-release.yml
##########
@@ -0,0 +1,33 @@
+name: Release Charts
+
+on:
+  push:
+    branches:
+      - '**'
+
+jobs:
+  release:

Review comment:
       We need a way to lint the chart in order to make sure that we're not 
clobbering versions. Take a look at this tool: 
https://github.com/helm/chart-testing
   
   It will check the current branch against master and will yell if you made 
chart changes, but forgot to bump the Chart version.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to