danielewood commented on pull request #14163:
URL: https://github.com/apache/superset/pull/14163#issuecomment-820603543


   Has this been tested? I was going to be submitting a nearly identical PR. I 
ran into some issues when creating my action. Namely I needed to add the 
upstream chart repos to the released action. You can see what I did and copy 
that over if you want:
   
https://github.com/danielewood/charts/blob/f38d51ffc34e46fe0e58d561878fed3e1ac326b1/.github/workflows/release-charts.yaml#L24-L26
   
   
   
   Also, is it the intent to publish a new chart on every PR merge? I would 
assume you only publish a new chart of you have modified the existing charts. 
   
   You can add:
   ```yaml 
   paths:
       - 'helm/**'
    ```
   To make this action trigger on only modifications to the charts. 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to