amitmiran137 commented on pull request #14217: URL: https://github.com/apache/superset/pull/14217#issuecomment-823254101
> super valuable feature, functionalities LGTM! This could be considered as 'drilldown' by some definitions. > It could get fairly complicated when multiple filters are applied to different chart types on the same dashboard. > should this action be globally applied to the dashboard? what about charts without groupby columns? > > * always sort by metrics 🟢 > * query group-by always take precedence 🟢 > * dashboard group-by value select order sets the column order 🟢 > * when a native group-by column is the same as a query group-by and is added to the table, it doesn't affect original group-by order. 🟢 > > A couple of comments > > 1. Saved native groupby filters should be carried back to Explore view, with the warning sign, for consistency. Unless we want to change the existing behavior for all. 🌕 @villebro @ktmud @zhaoyongjie thoughts? > 2. Add drag and drop in native filter for reordering select values. Since order actually matters now. 🌕 > > Screen.Recording.2021-04-19.at.10.31.28.PM.mov cross filter scoping is already enforcing the scope of groupby , we should generify the naming here : filters-->actions(or something) cross (?) or interactive -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
